Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch keychain's errSecUserCanceled #119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JulianToledano
Copy link

@JulianToledano JulianToledano commented Jan 18, 2023

We found a bug while making use of this package on the cosmos-sdk. If a user denies to enter the password in the prompt while using keychain, a misleading error is returned (more info in the issue). This is because errSecUserCanceled is not being catch. This PR catch that error and return an expected error

* Update gitignore

* Add ErrAccessDenied error

* Add error description on errSecUserCanceled

* Run CI on pull requests
@tac0turtle
Copy link

@mtibben any chance we can get this merged, it would allow us to unfork this repository

@ainhoa-a
Copy link

@mtibben @tac0turtle any chances of merging this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants